Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Testing StackTraceMetadata tests on tvos #91322

Closed
wants to merge 2 commits into from
Closed

[wip] Testing StackTraceMetadata tests on tvos #91322

wants to merge 2 commits into from

Conversation

ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Aug 30, 2023 •
edited
Loading

This is just a test of running StackTraceMetadata runtime test on tvos with NativeAOT in order to find the root cause of regression being tracked here: #90460

The failure is a bit mysterious since the program should return either 1 or 100:

runtime/src/tests/nativeaot/SmokeTests/StackTraceMetadata/StackTraceMetadata.cs

Line 22 in 08b6655

return expected == actual ? 100 : 1;

but it returns 0 when it fails as seen below:

  • On success test reports:
[05:37:33.5730610] Launched application 'net.dot.nativeaot_SmokeTests_StackTraceMetadata' on 'DNCENGTVOS-107' with pid 4737
[05:37:33.7952430] 2023-08-11 02:37:33.843 nativeaot_SmokeTests_StackTraceMetadata[4737:29832588]    at System.Environment.get_StackTrace() + 0x24
[05:37:33.7952820]    at Program.Main() + 0x10
[05:37:33.7952900]    at nativeaot_SmokeTests_StackTraceMetadata!<BaseAddress>+0xbecb8
[05:37:33.8053630] Xamarin.Hosting: Process '4737' exited with exit code 100 or crashing signal .
  • On failure test reports:
[17:39:00.6161080] 2023-08-11 14:39:00.573 nativeaot_SmokeTests_StackTraceMetadata[36488:33703418]    at System.Environment.get_StackTrace() + 0x24
[17:39:00.6161480]    at Program.Main() + 0x10
[17:39:00.6161560]    at nativeaot_SmokeTests_StackTraceMetadata!<BaseAddress>+0xbec38
[17:39:00.6299390] Xamarin.Hosting: Process '36488' exited with exit code 0 or crashing signal .
[17:39:00.6306590] Application 'net.dot.nativeaot_SmokeTests_StackTraceMetadata' terminated (with exit code '0' and/or crashing signal ').

Final note

The test is passing on:

  • ios-arm64 on CI and locally
  • tvossimulator-x64 on CI (don't have a x64 simulator to try locally)
  • tvossimulator-arm64 locally (CI does not have dedicated job for this platform)

@ivanpovazan ivanpovazan added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 30, 2023
@ghost ghost assigned ivanpovazan Aug 30, 2023
@ghost
Copy link

ghost commented Aug 30, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is just a test of running StackTraceMetadata runtime test on tvos with NativeAOT in order to find the root cause of regression being tracked here: #90460

The failure is a bit mysterious since the program should return either 1 or 100:

runtime/src/tests/nativeaot/SmokeTests/StackTraceMetadata/StackTraceMetadata.cs

Line 22 in 08b6655

return expected == actual ? 100 : 1;

but it returns 0 when it fails as seen below:

  • On success test reports:
[05:37:33.5730610] Launched application 'net.dot.nativeaot_SmokeTests_StackTraceMetadata' on 'DNCENGTVOS-107' with pid 4737
[05:37:33.7952430] 2023-08-11 02:37:33.843 nativeaot_SmokeTests_StackTraceMetadata[4737:29832588]    at System.Environment.get_StackTrace() + 0x24
[05:37:33.7952820]    at Program.Main() + 0x10
[05:37:33.7952900]    at nativeaot_SmokeTests_StackTraceMetadata!<BaseAddress>+0xbecb8
[05:37:33.8053630] Xamarin.Hosting: Process '4737' exited with exit code 100 or crashing signal .
  • On failure test reports:
[17:39:00.6161080] 2023-08-11 14:39:00.573 nativeaot_SmokeTests_StackTraceMetadata[36488:33703418]    at System.Environment.get_StackTrace() + 0x24
[17:39:00.6161480]    at Program.Main() + 0x10
[17:39:00.6161560]    at nativeaot_SmokeTests_StackTraceMetadata!<BaseAddress>+0xbec38
[17:39:00.6299390] Xamarin.Hosting: Process '36488' exited with exit code 0 or crashing signal .
[17:39:00.6306590] Application 'net.dot.nativeaot_SmokeTests_StackTraceMetadata' terminated (with exit code '0' and/or crashing signal ').
Author: ivanpovazan
Assignees: ivanpovazan
Labels:

NO-MERGE, NO-REVIEW, area-NativeAOT-coreclr
Milestone: -

@ivanpovazan
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

With the testing changes in this PR the test passes on tvos-arm64 lane with:

[08:47:40.5339720] 2023-08-30 05:47:40.620 nativeaot_SmokeTests_StackTraceMetadata[61221:35950816] Current stack trace:    at System.Environment.get_StackTrace() + 0x24
[08:47:40.5340070]    at Program.Main() + 0x20
[08:47:40.5340130]    at nativeaot_SmokeTests_StackTraceMetadata!<BaseAddress>+0xbef38
[08:47:40.5340180] 2023-08-30 05:47:40.621 nativeaot_SmokeTests_StackTraceMetadata[61221:35950816] Exit code: 100
[08:47:40.5872490] Xamarin.Hosting: Process '61221' exited with exit code 100 or crashing signal .
[08:47:40.5881260] Application 'net.dot.nativeaot_SmokeTests_StackTraceMetadata' terminated (with exit code '100' and/or crashing signal ').

@ghost
Copy link

ghost commented Sep 29, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Sep 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ivanpovazan ivanpovazan

Labels
area-NativeAOT-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivanpovazan